linux-ext4 - Re: [PATCH 27/28] ext4: Convert BUG_ON checks to use ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 06 Mar 2010 23:51:36 -0600
From:	Eric Sandeen <sandeen@...hat.com>
To:	tytso@....edu
CC:	"Aneesh Kumar K. V" <aneesh.kumar@...ux.vnet.ibm.com>,
	Ext4 Developers List <linux-ext4@...r.kernel.org>,
	Frank Mayhar <fmayhar@...gle.com>
Subject: Re: [PATCH 27/28] ext4: Convert BUG_ON checks to use ext4_error()
 instead

tytso@....edu wrote:
> On Sat, Mar 06, 2010 at 06:33:48PM +0530, Aneesh Kumar K. V wrote:
>> I guess ext4_error and ext4_warning are now not taking __func__. So we
>> to be consistant with thos i this this can be in lower case even though
>> they are #defines.
> 
> Or maybe we should rename them be EXT4_ERROR and EXT4_WARNING.  What
> do other people think?
> 
> 						- Ted


As the originator of the lower-case ext4_error and ext4_warning macros,
I don't much care.

I find the lower case more readable, but if the expectation in fs/extN is 
that ALL_MACROS_SHALL_BE_UPPER_CASE, that's fine by me.

-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html