linux-ext4 - Re: [incomplete PATCH] ext4: avoid overflow in fiemap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 6 Mar 2010 22:38:18 -0500
From:	tytso@....edu
To:	Leonard Michlmayr <leonard.michlmayr@...il.com>
Cc:	Akira Fujita <a-fujita@...jp.nec.com>,
	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [incomplete PATCH] ext4: avoid overflow in fiemap

On Thu, Mar 04, 2010 at 11:28:35PM +0100, Leonard Michlmayr wrote:
> A __u32 cannot hold the maximum number of blocks in a file. This may
> lead to an overflow if a fiemap request has length = s_maxbytes.
> 
> I still get a segfault, I have to go through it again. This is just for
> your information. I will work on it tomorrow.

Check and see if it's still a problem with what I ultimately ended up
pushing to Linus.  Yes, the way I chose to fix things means that we'll
never do more than 2**32-1 blocks at a time with fiemap, but in
practice there's a limit to the number of extents that can be returned
in a single fiemap call anyway, so in practice this shouldn't be a
problem.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html