linux-hardening - Re: [PATCH] efi: pstore: Allow dynamic initialization based on module parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 16 Jan 2024 08:29:32 -0300
From: "Guilherme G. Piccoli" <gpiccoli@...lia.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: linux-efi@...r.kernel.org, ardb@...nel.org, keescook@...omium.org,
 tony.luck@...el.com, linux-hardening@...r.kernel.org, kernel@...ccoli.net,
 kernel-dev@...lia.com
Subject: Re: [PATCH] efi: pstore: Allow dynamic initialization based on module
 parameter

On 16/01/2024 05:46, Greg KH wrote:
> On Mon, Jan 15, 2024 at 06:20:45PM -0300, Guilherme G. Piccoli wrote:
>> On 03/01/2024 15:40, Guilherme G. Piccoli wrote:
>>> The efi-pstore module parameter "pstore_disable" warrants that users
>>> are able to deactivate such backend. There is also a Kconfig option
>>> for the default value of this parameter. It was originally added due
>>> to some bad UEFI FW implementations that could break with many variables
>>> written.
>>>
>>> Some distros (such as Arch Linux) set this in their config file still
>>> nowadays. And once it is set, even being a writable module parameter,
>>> there is effectively no way to make use of efi-pstore anymore.
>>> If "pstore_disable" is set to true, the init function of the module exits
>>> early and is never called again after the initcall processing.
>>>
>>> Let's switch this module parameter to have a callback and perform the
>>> pstore backend registration again each time it's set from Y->N (and
>>> vice-versa). With this, the writable nature of the parameter starts to
>>> make sense, given that users now can switch back to using efi-pstore
>>> or not during runtime by writing into it.
>>
>> Hi folks, a friendly ping - any comments on this one, suggestions?
> 
> It's the middle of the merge window, not much anyone can do until after
> that is over to pick up new stuff.
> 
> thanks,
> 
> greg k-h
> 

OK, that's fine! No hurries, and thanks for your response Greg :)