linux-hardening - Re: [PATCH v2 0/4] kunit: Add helpers for creating test-managed devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 13 Dec 2023 16:04:52 +0100
From: Maxime Ripard <mripard@...nel.org>
To: davidgow@...gle.com
Cc: Rae Moar <rmoar@...gle.com>, 
	Brendan Higgins <brendan.higgins@...ux.dev>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Matti Vaittinen <mazziesaccount@...il.com>, Stephen Boyd <sboyd@...nel.org>, 
	Shuah Khan <skhan@...uxfoundation.org>, Jonathan Corbet <corbet@....net>, 
	Kees Cook <keescook@...omium.org>, Liam Girdwood <lgirdwood@...il.com>, 
	Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, 
	linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com, linux-doc@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org, linux-sound@...r.kernel.org
Subject: Re: [PATCH v2 0/4] kunit: Add helpers for creating test-managed
 devices

Hi David,

On Fri, Dec 08, 2023 at 06:09:28PM +0800, davidgow@...gle.com wrote:
> KUnit tests often need to provide a struct device, and thus far have
> mostly been using root_device_register() or platform devices to create
> a 'fake device' for use with, e.g., code which uses device-managed
> resources. This has several disadvantages, including not being designed
> for test use, scattering files in sysfs, and requiring manual teardown
> on test exit, which may not always be possible in case of failure.
> 
> Instead, introduce a set of helper functions which allow devices
> (internally a struct kunit_device) to be created and managed by KUnit --
> i.e., they will be automatically unregistered on test exit. These
> helpers can either use a user-provided struct device_driver, or have one
> automatically created and managed by KUnit. In both cases, the device
> lives on a new kunit_bus.
> 
> This is a follow-up to a previous proposal here:
> https://lore.kernel.org/linux-kselftest/20230325043104.3761770-1-davidgow@google.com/
> 
> (The kunit_defer() function in the first patch there has since been
> merged as the 'deferred actions' feature.)
> 
> My intention is to take this whole series in via the kselftest/kunit
> branch, but I'm equally okay with splitting up the later patches which
> use this to go via the various subsystem trees in case there are merge
> conflicts.

Could you take (and apply eventually) that patch as part of your series?
https://lore.kernel.org/linux-kselftest/20231205090405.153140-1-mripard@kernel.org/

Thanks
Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)