[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 11 Oct 2023 01:12:52 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: Justin Stitt <justinstitt@...gle.com>
Cc: Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-hardening@...r.kernel.org,
Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH] net: dsa: vsc73xx: replace deprecated strncpy with
ethtool_sprintf
On Tue, Oct 10, 2023 at 02:49:26PM -0700, Justin Stitt wrote:
> On Tue, Oct 10, 2023 at 4:20 AM Vladimir Oltean <olteanv@...il.com> wrote:
> > Here you don't use "%s", but everywhere else you do. Can't you just pass
> > the counter name everywhere, without "%s"?
>
> Because it's a string literal, no warning there. Maybe an argument
> regarding style could be made. I have no style preference here
> so I could send v2 if you feel strongly about it.
No, leave it alone here, don't add the "%s" where it's not needed.
But I guess you'll have to send a v2 anyway due to the other comment.
Powered by blists - more mailing lists