linux-hardening - Re: [PATCH v2 0/5] Introduce new wrappers to copy user-arrays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Sep 2023 01:53:47 +0000
From:   Zack Rusin <zackr@...are.com>
To:     "nick.alcock@...cle.com" <nick.alcock@...cle.com>,
        "tzimmermann@...e.de" <tzimmermann@...e.de>,
        "ebiederm@...ssion.com" <ebiederm@...ssion.com>,
        "brauner@...nel.org" <brauner@...nel.org>,
        "keescook@...omium.org" <keescook@...omium.org>,
        "airlied@...il.com" <airlied@...il.com>,
        "code@...dh.me" <code@...dh.me>,
        "pstanner@...hat.com" <pstanner@...hat.com>,
        "ddiss@...e.de" <ddiss@...e.de>,
        "andy@...nel.org" <andy@...nel.org>,
        "mripard@...nel.org" <mripard@...nel.org>,
        "maarten.lankhorst@...ux.intel.com" 
        <maarten.lankhorst@...ux.intel.com>,
        "mcgrof@...nel.org" <mcgrof@...nel.org>,
        "daniel@...ll.ch" <daniel@...ll.ch>
CC:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "kexec@...ts.infradead.org" <kexec@...ts.infradead.org>,
        Linux-graphics-maintainer <Linux-graphics-maintainer@...are.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-hardening@...r.kernel.org" <linux-hardening@...r.kernel.org>
Subject: Re: [PATCH v2 0/5] Introduce new wrappers to copy user-arrays

On Fri, 2023-09-08 at 21:59 +0200, Philipp Stanner wrote:
> Hi!
> 
> David Airlie suggested that we could implement new wrappers around
> (v)memdup_user() for duplicating user arrays.
> 
> This small patch series first implements the two new wrapper functions
> memdup_array_user() and vmemdup_array_user(). They calculate the
> array-sizes safely, i.e., they return an error in case of an overflow.
> 
> It then implements the new wrappers in two components in kernel/ and two
> in the drm-subsystem.
> 
> In total, there are 18 files in the kernel that use (v)memdup_user() to
> duplicate arrays. My plan is to provide patches for the other 14
> successively once this series has been merged.
> 
> 
> Changes since v1:
> - Insert new headers alphabetically ordered
> - Remove empty lines in functions' docstrings
> - Return -EOVERFLOW instead of -EINVAL from wrapper functions
> 
> 
> @Andy:
> I test-build it for UM on my x86_64. Builds successfully.
> A kernel build (localmodconfig) for my Fedora38 @ x86_64 does also boot
> fine.
> 
> If there is more I can do to verify the early boot stages are fine,
> please let me know!
> 
> P.
> 
> Philipp Stanner (5):
>   string.h: add array-wrappers for (v)memdup_user()
>   kernel: kexec: copy user-array safely
>   kernel: watch_queue: copy user-array safely
>   drm_lease.c: copy user-array safely
>   drm: vmgfx_surface.c: copy user-array safely
> 
>  drivers/gpu/drm/drm_lease.c             |  4 +--
>  drivers/gpu/drm/vmwgfx/vmwgfx_surface.c |  4 +--
>  include/linux/string.h                  | 40 +++++++++++++++++++++++++
>  kernel/kexec.c                          |  2 +-
>  kernel/watch_queue.c                    |  2 +-
>  5 files changed, 46 insertions(+), 6 deletions(-)
> 

Series, and in particular the vmwgfx changes, look good to me.

Reviewed-by: Zack Rusin <zackr@...are.com>