linux-hardening - [PATCH 0/2] ocfs2: Replace strlcpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 Aug 2023 21:54:24 +0000
From:   Azeem Shaikh <azeemshaikh38@...il.com>
To:     Mark Fasheh <mark@...heh.com>, Joel Becker <jlbec@...lplan.org>,
        Joseph Qi <joseph.qi@...ux.alibaba.com>
Cc:     linux-hardening@...r.kernel.org,
        Azeem Shaikh <azeemshaikh38@...il.com>,
        ocfs2-devel@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Christian Brauner <brauner@...nel.org>,
        Dave Chinner <dchinner@...hat.com>,
        Jeff Layton <jlayton@...nel.org>
Subject: [PATCH 0/2] ocfs2: Replace strlcpy with strscpy

Hi,

The main patch this series is targeting is [PATCH 2] which replaces
strlcpy() call with strscpy(). However, while I was tinkering through
the code I noticed that `module_param_call` is marked obsolete and
`module_param_cb` is preferred instead. So I have included [PATCH 1]
which does that.

A crucial thing in [PATCH 2] I would like to bring to reviewer's
attention is that it changes behavior for the case where
sizeof(@buffer) < DLMFS_CAPABILITIES. Currently, this is silently ignored
but with the current change it returns -errno.

Thanks,
Azeem

Azeem Shaikh (2):
  Replace module_param_call with module_param_cb
  Replace strlcpy with strscpy

 fs/ocfs2/dlmfs/dlmfs.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

--
2.42.0.283.g2d96d420d3-goog