linux-hardening - Re: [PATCH v4 3/8] dt-bindings: clock: Add Marvell PXA1908 clock bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 08 Aug 2023 13:03:33 +0200
From:   Duje Mihanović <duje.mihanovic@...le.hr>
To:     Conor Dooley <conor@...nel.org>
Cc:     Conor Dooley <conor+dt@...nel.org>,
        Lubomir Rintel <lkundrak@...sk>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Andy Shevchenko <andy@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Tony Luck <tony.luck@...el.com>,
        "Guilherme G. Piccoli" <gpiccoli@...lia.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-hardening@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        afaerber@...e.de,
        Duje Mihanović <duje.mihanovic@...le.hr>
Subject: Re: [PATCH v4 3/8] dt-bindings: clock: Add Marvell PXA1908 clock bindings

On Tuesday, August 8, 2023 12:46:23 PM CEST Conor Dooley wrote:
> On Tue, Aug 08, 2023 at 12:41:22PM +0200, Duje Mihanović wrote:
> > They are used by the clock driver when calling mmp_clk_init which then 
uses
> > that as the size of a struct clk array it allocates. In retrospect, 50 for
> > each block may be too much as from what I can tell by reading the
> > mmp_register_* functions (number of clocks + 1) for each block should be
> > enough, anything less than that causes a null pointer dereference sometime
> > during clock initialization.
> 
> I think you might have misread my question, I'm not really interested in
> the implementation detail of the driver. If these are not used in
> devicetree, remove them - otherwise they are being needlessly added to
> the ABI.

Should I also do this in the rest of the MMP clock drivers?

Regards,
Duje