linux-hardening - Re: [RFC v2 7/9] kunit: time: Mark test as slow using test attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Jul 2023 15:39:26 +0800
From:   David Gow <davidgow@...gle.com>
To:     Rae Moar <rmoar@...gle.com>
Cc:     shuah@...nel.org, dlatypov@...gle.com, brendan.higgins@...ux.dev,
        linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
        linux-kernel@...r.kernel.org, keescook@...omium.org,
        linux-hardening@...r.kernel.org, jstultz@...gle.com,
        tglx@...utronix.de, sboyd@...nel.org
Subject: Re: [RFC v2 7/9] kunit: time: Mark test as slow using test attributes

On Sat, 8 Jul 2023 at 05:10, Rae Moar <rmoar@...gle.com> wrote:
>
> Mark the time KUnit test, time64_to_tm_test_date_range, as slow using test
> attributes.
>
> This test ran relatively much slower than most other KUnit tests.
>
> By marking this test as slow, the test can now be filtered using the KUnit
> test attribute filtering feature. Example: --filter "speed>slow". This will
> run only the tests that have speeds faster than slow. The slow attribute
> will also be outputted in KTAP.
>
> Signed-off-by: Rae Moar <rmoar@...gle.com>
> ---

Thanks: this test is slow enough to really annoy me on some machines.
(It's possibly even on the edge of "very_slow" territory, though I
suspect "slow" is better.)

Reviewed-by: David Gow <davidgow@...gle.com>

Cheers,
-- David


>
> Changes since v1:
> - No changes.
>
>  kernel/time/time_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/time/time_test.c b/kernel/time/time_test.c
> index 831e8e779ace..ca058c8af6ba 100644
> --- a/kernel/time/time_test.c
> +++ b/kernel/time/time_test.c
> @@ -86,7 +86,7 @@ static void time64_to_tm_test_date_range(struct kunit *test)
>  }
>
>  static struct kunit_case time_test_cases[] = {
> -       KUNIT_CASE(time64_to_tm_test_date_range),
> +       KUNIT_CASE_SLOW(time64_to_tm_test_date_range),
>         {}
>  };
>
> --
> 2.41.0.255.g8b1d071c50-goog
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4003 bytes)