linux-ext4 - Re: [PATCH 0/7] ext4: support adding multi-delalloc blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 10 Apr 2024 11:59:33 +0800
From: Zhang Yi <yi.zhang@...weicloud.com>
To: linux-ext4@...r.kernel.org
Cc: linux-fsdevel@...r.kernel.org, tytso@....edu, adilger.kernel@...ger.ca,
 jack@...e.cz, yi.zhang@...wei.com, chengzhihao1@...wei.com,
 yukuai3@...wei.com
Subject: Re: [PATCH 0/7] ext4: support adding multi-delalloc blocks

On 2024/3/30 20:02, Zhang Yi wrote:
> From: Zhang Yi <yi.zhang@...wei.com>
> 
> Hello!
> 
> This patch series is the part 2 prepartory changes of the buffered IO
> iomap conversion, I picked them out from my buffered IO iomap conversion
> RFC series v3[1], and add bigalloc feature support.
> 
> The first 6 patches make ext4_insert_delayed_block() call path support
> inserting multi-delalloc blocks once a time, and the last patch makes
> ext4_da_map_blocks() buffer_head unaware.
> 
> This patch set has been passed 'kvm-xfstests -g auto' tests, I hope it
> could be reviewed and merged first.
> 

I've found an incorrect delalloc reserve space count and incorrect extent
type issue in the current ext4 code while improving my iomap conversion.
I'd suggest to fix this issue first, so please drop this series and look
at my v2 series for details.

Thanks,
Yi.

> [1] https://lore.kernel.org/linux-ext4/20240127015825.1608160-1-yi.zhang@huaweicloud.com/
> 
> Thanks,
> Yi.
> 
> Zhang Yi (7):
>   ext4: trim delalloc extent
>   ext4: drop iblock parameter
>   ext4: make ext4_es_insert_delayed_block() insert multi-blocks
>   ext4: make ext4_da_reserve_space() reserve multi-clusters
>   ext4: factor out check for whether a cluster is allocated
>   ext4: make ext4_insert_delayed_block() insert multi-blocks
>   ext4: make ext4_da_map_blocks() buffer_head unaware
> 
>  fs/ext4/extents_status.c    |  63 +++++++++-----
>  fs/ext4/extents_status.h    |   5 +-
>  fs/ext4/inode.c             | 165 ++++++++++++++++++++++--------------
>  include/trace/events/ext4.h |  26 +++---
>  4 files changed, 162 insertions(+), 97 deletions(-)
>