linux-ext4 - Re: [PATCH] mm: Change calling convention for ->huge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 18 Aug 2023 13:15:47 +0800
From:   kernel test robot <lkp@...el.com>
To:     "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     oe-kbuild-all@...ts.linux.dev,
        Linux Memory Management List <linux-mm@...ck.org>,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        linux-fsdevel@...r.kernel.org, nvdimm@...ts.linux.dev,
        linux-xfs@...r.kernel.org, linux-ext4@...r.kernel.org,
        linux-erofs@...ts.ozlabs.org, linux-cxl@...r.kernel.org
Subject: Re: [PATCH] mm: Change calling convention for ->huge_fault

Hi Matthew,

kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Matthew-Wilcox-Oracle/mm-Change-calling-convention-for-huge_fault/20230818-040348
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20230817200150.1230317-1-willy%40infradead.org
patch subject: [PATCH] mm: Change calling convention for ->huge_fault
config: arc-randconfig-r043-20230818 (https://download.01.org/0day-ci/archive/20230818/202308181315.Z4HfWZsh-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230818/202308181315.Z4HfWZsh-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308181315.Z4HfWZsh-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/asm-generic/io.h:1048,
                    from arch/arc/include/asm/io.h:232,
                    from include/linux/io.h:13,
                    from include/linux/irq.h:20,
                    from include/asm-generic/hardirq.h:17,
                    from ./arch/arc/include/generated/asm/hardirq.h:1,
                    from include/linux/hardirq.h:11,
                    from include/linux/interrupt.h:11,
                    from include/linux/kernel_stat.h:9,
                    from mm/memory.c:42:
   mm/memory.c: In function 'create_huge_pmd':
>> include/linux/pgtable.h:8:38: error: 'PTE_SHIFT' undeclared (first use in this function); did you mean 'PUD_SHIFT'?
       8 | #define PMD_ORDER       (PMD_SHIFT - PTE_SHIFT)
         |                                      ^~~~~~~~~
   mm/memory.c:4876:53: note: in expansion of macro 'PMD_ORDER'
    4876 |                 return vma->vm_ops->huge_fault(vmf, PMD_ORDER);
         |                                                     ^~~~~~~~~
   include/linux/pgtable.h:8:38: note: each undeclared identifier is reported only once for each function it appears in
       8 | #define PMD_ORDER       (PMD_SHIFT - PTE_SHIFT)
         |                                      ^~~~~~~~~
   mm/memory.c:4876:53: note: in expansion of macro 'PMD_ORDER'
    4876 |                 return vma->vm_ops->huge_fault(vmf, PMD_ORDER);
         |                                                     ^~~~~~~~~
   mm/memory.c: In function 'wp_huge_pmd':
>> include/linux/pgtable.h:8:38: error: 'PTE_SHIFT' undeclared (first use in this function); did you mean 'PUD_SHIFT'?
       8 | #define PMD_ORDER       (PMD_SHIFT - PTE_SHIFT)
         |                                      ^~~~~~~~~
   mm/memory.c:4896:60: note: in expansion of macro 'PMD_ORDER'
    4896 |                         ret = vma->vm_ops->huge_fault(vmf, PMD_ORDER);
         |                                                            ^~~~~~~~~


vim +8 include/linux/pgtable.h

     7	
   > 8	#define PMD_ORDER	(PMD_SHIFT - PTE_SHIFT)
     9	#define PUD_ORDER	(PUD_SHIFT - PTE_SHIFT)
    10	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki