linux-ext4 - Re: [PATCH] ext4: set FMODE_CAN_ODIRECT instead of a dummy direct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 13 Jun 2023 19:27:23 +0530
From:   Ritesh Harjani (IBM) <ritesh.list@...il.com>
To:     Christoph Hellwig <hch@....de>
Cc:     Christoph Hellwig <hch@....de>, tytso@....edu,
        linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: set FMODE_CAN_ODIRECT instead of a dummy direct_IO method

Christoph Hellwig <hch@....de> writes:

> On Tue, Jun 13, 2023 at 11:00:19AM +0530, Ritesh Harjani wrote:
>> why do we require .direct_IO function op for any of the dax_aops?
>> IIUC, any inode if it supports DAX i.e. IS_DAX(inode), then it takes the
>> separate path in file read/write iter path.
>>
>> so it should never do ->direct_IO on an inode which supports DAX right?
>
> do_dentry_open rejects opens with O_DIRECT if FMODE_CAN_ODIRECT is
> not set.  So we either needs to set that manually or because there is a
> ->direct_IO if we want to keep supporting O_DIRECT opens for DAX
> files, which we've traditionally supported.

Ok, so for DAX it was mainly to support file opens with O_DIRECT semantics.

Thanks
-ritesh