linux-ext4 - Re: [PATCH] ext4: Fix lockdep warning when enabling MMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 13 May 2023 00:59:28 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     "Theodore Ts'o" <tytso@....edu>, linux-ext4@...r.kernel.org,
        Christian Brauner <brauner@...nel.org>,
        syzbot+aacb82fca60873422114@...kaller.appspotmail.com
Subject: Re: [PATCH] ext4: Fix lockdep warning when enabling MMP


On Tue, 11 Apr 2023 14:10:19 +0200, Jan Kara wrote:
> When we enable MMP in ext4_multi_mount_protect() during mount or
> remount, we end up calling sb_start_write() from write_mmp_block(). This
> triggers lockdep warning because freeze protection ranks above s_umount
> semaphore we are holding during mount / remount. The problem is harmless
> because we are guaranteed the filesystem is not frozen during mount /
> remount but still let's fix the warning by not grabbing freeze
> protection from ext4_multi_mount_protect().
> 
> [...]

Applied, thanks!

[1/1] ext4: Fix lockdep warning when enabling MMP
      commit: 949f95ff39bf188e594e7ecd8e29b82eb108f5bf

Best regards,
-- 
Theodore Ts'o <tytso@....edu>