linux-ext4 - Re: [PATCH v2 1/11] ext4: Remove ordered data support from ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 5 Dec 2022 11:17:39 +0100
From:   Jan Kara <jack@...e.cz>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Jan Kara <jack@...e.cz>, Ted Tso <tytso@....edu>,
        linux-ext4@...r.kernel.org, Ritesh Harjani <ritesh.list@...il.com>
Subject: Re: [PATCH v2 1/11] ext4: Remove ordered data support from
 ext4_writepage()

On Sat 03-12-22 23:06:47, Christoph Hellwig wrote:
> > + * This function is now used only when journaling data. We cannot start
> > + * transaction directly because transaction start ranks above page lock so we
> > + * have to do some magic.
> >   */
> > +static int ext4_writepage(struct page *page, struct writeback_control *wbc,
> > +			  void *data)
> 
> Maybe call this ext4_journalled_writepage now to make the limitation
> more clear?  And/or fold __ext4_journalled_writepage into while we're
> at it.

Yeah, I've renamed it to ext4_journalled_writepage. I've refrained from the
folding of __ext4_journalled_writepage() because that is not completely
trivial (due to goto labels, variable naming...) so it would require
separate patch and I'll just spare that for the cleanup of the whole
journalled writeout path.

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR