linux-ext4 - Re: [PATCH 1/3] common/rc: move ext4-specific helpers into a separate common/ext4 file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Aug 2022 05:32:02 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     "Darrick J. Wong" <djwong@...nel.org>
Cc:     guaneryu@...il.com, zlang@...hat.com, linux-xfs@...r.kernel.org,
        fstests@...r.kernel.org, guan@...u.me, tytso@....edu,
        linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/3] common/rc: move ext4-specific helpers into a
 separate common/ext4 file

On Tue, Aug 09, 2022 at 02:00:46PM -0700, Darrick J. Wong wrote:
> --- a/common/config
> +++ b/common/config
> @@ -512,6 +512,10 @@ _source_specific_fs()
>  		;;
>  	ext4)
>  		[ "$MKFS_EXT4_PROG" = "" ] && _fatal "mkfs.ext4 not found"
> +		. ./common/ext4
> +		;;
> +	ext2|ext3|ext4dev)
> +		. ./common/ext4

Not really new in this patch, but why does ext4 check for a specific
mkfs and the others don't?

Also can we drop ext4dev while we're at it?

The patch itself looks good:

Reviewed-by: Christoph Hellwig <hch@....de>