linux-ext4 - Re: [PATCH] e2scrub: Remove PATH setting from the scripts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Apr 2020 08:17:20 -0700
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     Lukas Czerner <lczerner@...hat.com>
Cc:     linux-ext4@...r.kernel.org, Ted Tso <tytso@....edu>
Subject: Re: [PATCH] e2scrub: Remove PATH setting from the scripts

On Thu, Apr 02, 2020 at 03:47:16PM +0200, Lukas Czerner wrote:
> We don't want to override system setting by changing the PATH. This
> should remain under administrator/user control.
> 
> Signed-off-by: Lukas Czerner <lczerner@...hat.com>

Looks ok to me,
Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com>

--D

> ---
>  scrub/e2scrub.in     | 2 --
>  scrub/e2scrub_all.in | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/scrub/e2scrub.in b/scrub/e2scrub.in
> index 30ab7cbd..7c3f46e9 100644
> --- a/scrub/e2scrub.in
> +++ b/scrub/e2scrub.in
> @@ -23,8 +23,6 @@
>  # check filesystems in VGs that have at least 256MB (or so) of
>  # free space.
>  
> -PATH=/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin
> -
>  if (( $EUID != 0 )); then
>      echo "e2scrub must be run as root"
>      exit 1
> diff --git a/scrub/e2scrub_all.in b/scrub/e2scrub_all.in
> index 4288b969..b6a7d0ad 100644
> --- a/scrub/e2scrub_all.in
> +++ b/scrub/e2scrub_all.in
> @@ -18,8 +18,6 @@
>  #  along with this program; if not, write the Free Software Foundation,
>  #  Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301, USA.
>  
> -PATH=/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin
> -
>  if (( $EUID != 0 )); then
>      echo "e2scrub_all must be run as root"
>      exit 1
> -- 
> 2.21.1
>