linux-ext4 - Re: [PATCH] ext2: adjust block num when retry allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 22 Oct 2019 13:36:18 +0800
From:   Chengguang Xu <cgxu519@...ernel.net>
To:     "Jan Kara" <jack@...e.cz>
Cc:     "jack" <jack@...e.com>, "linux-ext4" <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext2: adjust block num when retry allocation

 ---- 在 星期一, 2019-10-21 17:18:00 Jan Kara <jack@...e.cz> 撰写 ----
 > On Mon 21-10-19 07:23:26, Chengguang Xu wrote:
 > > Set block num to original *count in a case
 > > of retrying allocation in case num < *count
 > > 
 > > Signed-off-by: Chengguang Xu <cgxu519@...ernel.net>
 > > ---
 > > Hi Jan,
 > > 
 > > This patch is only compile-tested, I'm not sure if this
 > > kind of unexpected condition which causes reallocation
 > > will actually happen but baesd on the code the fix seems
 > > correct and better.
 > 
 > Yeah, you are right that we should reset 'num' back to *count. Although the
 > practial effect of this is minimal - we take this code path only when the
 > filesystem is corrupted. But still... Patch applied. Thanks!
 
Thanks for your review. I found another relevant bug in ext2_try_to_allocate()
today, I'll fix it up and  also plan to do some code cleanups for the allocation logic.
Do you prefer two separate patches for bugfix and cleanup or just put all in a patch series?

Thanks,
Chengguang