linux-ext4 - Re: [PATCH 00/10] fix coding style for ext2 filesystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Dec 2018 14:15:18 +0100
From:   Jan Kara <jack@...e.cz>
To:     Chengguang Xu <cgxu519@....com>
Cc:     jack@...e.com, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 00/10] fix coding style for ext2 filesystem

On Tue 13-11-18 08:04:38, Chengguang Xu wrote:
> This patch set fixes some coding style warnings which are from
> checkpatch.pl.
> 
> Detail warning/error messages are below:
> 
> WARNING: function definition argument 'struct inode *' should
> also have an identifier name
> 
> WARNING: space prohibited between function name and open
> parenthesis '(' 
> 
> WARNING: line over 80 characters
> 
> ERROR: "foo * bar" should be "foo *bar"

Thanks for the series! I had a look into the patches but I don't think
these whitespace fixes are really worth the churn. Sorry.

								Honza

-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR