linux-ext4 - Re: [PATCH] mm: have filemap_check_and_advance_wb_err clear AS_EIO/AS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 25 Sep 2017 10:17:48 +0200
From:   Jan Kara <jack@...e.cz>
To:     Jeff Layton <jlayton@...nel.org>
Cc:     linux-fsdevel@...r.kernel.org, Eryu Guan <eguan@...hat.com>,
        Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] mm: have filemap_check_and_advance_wb_err clear
 AS_EIO/AS_ENOSPC

On Fri 22-09-17 09:33:31, Jeff Layton wrote:
> From: Jeff Layton <jlayton@...hat.com>
> 
> Eryu noticed that he could sometimes get a leftover error reported when
> it shouldn't be on fsync with ext2 and non-journalled ext4. The problem
> is that writeback_single_inode still uses filemap_fdatawait. That picks
> up a previously set AS_EIO flag, which would ordinarily have been
> cleared before.
> 
> Since we're mostly using this function as a replacement for
> filemap_check_errors, have filemap_check_and_advance_wb_err clear AS_EIO
> and AS_ENOSPC when reporting an error. That should allow the new
> function to better emulate the behavior of the old with respect to these
> flags.
> 
> Reported-by: Eryu Guan <eguan@...hat.com>
> Signed-off-by: Jeff Layton <jlayton@...hat.com>

Looks good. You can add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  mm/filemap.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/mm/filemap.c b/mm/filemap.c
> index 870971e20967..404722ea0fdd 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -620,6 +620,14 @@ int file_check_and_advance_wb_err(struct file *file)
>  		trace_file_check_and_advance_wb_err(file, old);
>  		spin_unlock(&file->f_lock);
>  	}
> +
> +	/*
> +	 * We're mostly using this function as a drop in replacement for
> +	 * filemap_check_errors. Clear AS_EIO/AS_ENOSPC to emulate the effect
> +	 * that the legacy code would have had on these flags.
> +	 */
> +	clear_bit(AS_EIO, &mapping->flags);
> +	clear_bit(AS_ENOSPC, &mapping->flags);
>  	return err;
>  }
>  EXPORT_SYMBOL(file_check_and_advance_wb_err);
> -- 
> 2.13.5
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR