[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 27 Nov 2014 09:41:16 -0500
From: Theodore Ts'o <tytso@....edu>
To: Christoph Hellwig <hch@...radead.org>
Cc: Linux Filesystem Development List <linux-fsdevel@...r.kernel.org>,
Ext4 Developers List <linux-ext4@...r.kernel.org>,
Linux btrfs Developers List <linux-btrfs@...r.kernel.org>,
XFS Developers <xfs@....sgi.com>
Subject: Re: [PATCH-v4 1/7] vfs: split update_time() into update_time() and
write_time()
On Wed, Nov 26, 2014 at 11:23:28AM -0800, Christoph Hellwig wrote:
> As mentioned last round please move the addition of the is_readonly
> operation to the first thing in the series, so that the ordering makes
> more sense.
OK, will fix.
> Second I think this patch is incorrect for XFS - XFS uses ->update_time
> to set the time stampst in the dinode. These two need to be coherent
> as we can write out a dirty inode any time, so it needs to have the
> timestamp uptodate.
>
> Third update_time now calls mark_inode_dirty unconditionally, while
> previously it wasn't called when ->update_time was set. At least
> for XFS that's a major change in behavior as XFS never used VFS dirty
> tracking for metadata updates.
Thanks, I'll fix both of the above.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists