linux-ext4 - Re: [PATCH 06/34] debugfs: add LIBINTL to debugfs link command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 18 Oct 2014 12:10:14 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 06/34] debugfs: add LIBINTL to debugfs link command

On Fri, Oct 17, 2014 at 02:07:37PM -0700, Darrick J. Wong wrote:
> 
> True, but since debugfs pulls in plausible.o which uses _(), it still needs
> this patch to build on OSX 10.9.5.

Good point.  I'l fix it this way.  (Basically, it's really pointless
to link debugfs with LIBINTL since debugfs doesn't have any I18N
support, and I'd prefer to limit unnecessary bloat.)

	     	 	   	 	     - Ted

commit 831aa869e8b1b287ca921e7ae181a4cdca839099
Author: Theodore Ts'o <tytso@....edu>
Date:   Sat Oct 18 09:13:09 2014 -0400

    debugfs: fix build on systems that don't have gettext built-in
    
    Debugfs (unlike all of the other programs in e2fsprogs) is not set up
    to use translated strings.  So when building misc/plausible.c for
    debugfs, we need to disable NLS.
    
    Signed-off-by: Theodore Ts'o <tytso@....edu>

diff --git a/misc/nls-enable.h b/misc/nls-enable.h
index a91dcc1..2f62c01 100644
--- a/misc/nls-enable.h
+++ b/misc/nls-enable.h
@@ -1,4 +1,4 @@
-#ifdef ENABLE_NLS
+#if defined(ENABLE_NLS) && !defined(DEBUGFS)
 #include <libintl.h>
 #include <locale.h>
 #define _(a) (gettext (a))
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html