linux-ext4 - Re: [ext4:dev 56/60] fs/ext4/xattr.h:422:12: error: two or more data types in declaration specifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 03 Dec 2012 16:30:34 +0800
From:	Tao Ma <tm@....ma>
To:	Fengguang Wu <fengguang.wu@...el.com>
CC:	Tao Ma <boyu.mt@...bao.com>, linux-ext4@...r.kernel.org,
	Theodore Ts'o <tytso@....edu>
Subject: Re: [ext4:dev 56/60] fs/ext4/xattr.h:422:12: error: two or more data
 types in declaration specifiers

On 12/03/2012 02:18 PM, Fengguang Wu wrote:
> Tao,
> 
> Perhaps you can create an incremental fix, which allows Ted to easily
> check how it's fixed, and have the freedom to either fold it to the
> bad commit, or to append to HEAD. 
yeah, I have create an incremental fix and sent it out. Anyway, thanks
again for your splendid test framework.

Ted, please consider merging it. Thanks

Tao
> 
> Thanks,
> Fengguang
> 
> On Mon, Dec 03, 2012 at 01:37:52PM +0800, Tao Ma wrote:
>> Great thanks, Fengguang.
>>
>> So Ted,
>> 	do you want me to send a new patch set? Or you just want me to generate
>> a patch for all these warnings Fengguang found?
>>
>> Thanks
>> Tao
>>
>>
>> On 12/03/2012 01:12 PM, kbuild test robot wrote:
>>> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
>>> head:   e9f49e454264c1cdd793552bfeb44f337508201b
>>> commit: a7b0168d4a9bb78535827ddaf9c055963f5bd7aa [56/60] ext4: let fallocate handle inline data correctly
>>> config: i386-randconfig-m085 (attached as .config)
>>>
>>> All error/warnings:
>>>
>>> In file included from fs/ext4/dir.c:30:0:
>>> fs/ext4/xattr.h:422:12: error: two or more data types in declaration specifiers
>>> fs/ext4/xattr.h:422:16: warning: 'ext4_convert_inline_data' defined but not used [-Wunused-function]
>>> --
>>> In file included from fs/ext4/extents.c:45:0:
>>> fs/ext4/xattr.h:422:12: error: two or more data types in declaration specifiers
>>>
>>> vim +422 fs/ext4/xattr.h
>>>
>>> 18dfee69 Tao Ma 2012-12-02  416  static inline void ext4_inline_data_truncate(struct inode *inode,
>>> 18dfee69 Tao Ma 2012-12-02  417  					     int *has_inline)
>>> 18dfee69 Tao Ma 2012-12-02  418  {
>>> 18dfee69 Tao Ma 2012-12-02  419  	return;
>>> 18dfee69 Tao Ma 2012-12-02  420  }
>>> 18dfee69 Tao Ma 2012-12-02  421  
>>> a7b0168d Tao Ma 2012-12-02 @422  static int int ext4_convert_inline_data(struct inode *inode)
>>> a7b0168d Tao Ma 2012-12-02  423  {
>>> a7b0168d Tao Ma 2012-12-02  424  	return 0;
>>> a7b0168d Tao Ma 2012-12-02  425  }
>>>
>>> ---
>>> 0-DAY kernel build testing backend         Open Source Technology Center
>>> Fengguang Wu, Yuanhan Liu                              Intel Corporation
>>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html