linux-ext4 - Re: ext4 corruption during unexpected power cycle in the middle of writing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 6 Jun 2012 14:55:26 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	Ming Lei <Ming.Lei@...erbed.com>,
	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>
Subject: Re: ext4 corruption during unexpected power cycle in the middle of
 writing

On Wed, Jun 06, 2012 at 12:31:34AM -0500, Eric Sandeen wrote:
> Sort of.  You got:
> 
> > Free blocks count wrong (118366120, counted=76269471).
> > Fix? yes
> > 
> > Free inodes count wrong (30081013, counted=30081004).
> > Fix? yes
> 
> Those are the superblock counters, which aren't journaled - only the bg counters are logged via the journal, IIRC.

This has been partially addressed in e2fsprogs 1.42.3:

commit 2788cc879bbe667d28277e1d660b7e56514e5b30
Author: Andreas Dilger <adilger@...mcloud.com>
Date:   Tue Apr 24 16:22:48 2012 -0400

    e2fsck: quiet harmless inode/blocks errors
    
    Don't consider only an error in the superblock summary as incorrect.
    The kernel does not update this field except at unmount time, so
    don't print errors during a "-n" run if there is nothing else wrong.
    Any other unfixed errors will themselves mark the filesystem invalid.
    
    Signed-off-by: Andreas Dilger <adilger@...mcloud.com>
    Signed-off-by: Theodore Ts'o <tytso@....edu>

So e2fsck -n will silence the warnings, and e2fsck -p/-y will just fix
them automatically, although they are still getting printed.  Maybe I
should just mark these messages as one where they just print the fact
that we are adjusting the free blocks count, and avoid using the word
"wrong" --- at least if the filesystem has a journal --- so the error
message isn't as scary/misleading.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html