linux-ext4 - Re: [PATCH] e2fsprogs: fix potential null ptr defef in check_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 6 Mar 2009 02:38:11 -0500
From:	Theodore Tso <tytso@....edu>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] e2fsprogs: fix potential null ptr defef in
	check_for_modules()

On Tue, Feb 24, 2009 at 03:13:39PM -0600, Eric Sandeen wrote:
> The coverity scanner found this one.
> 
> If a line in modules.dep has a ":" but no "/" then:
> 
>                 if ((cp = strchr(buf, ':')) != NULL)
>                         *cp = 0;
>                 else
>                         continue;
>                 if ((cp = strrchr(buf, '/')) != NULL)
>                         cp++;
>                 /* XXX else cp is still null */
>                 i = strlen(cp);
> 
> ... we will deref a null pointer (cp).  This can be 
> demonstrated by putting a line like:
> 
> foo.ko:
> 
> into modules.dep.  The below change just says that if no "/" is
> found, treat the whole string as the module name.

Thanks, applied to the e2fsprogs git tree.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html