lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Mon, 12 May 2008 17:11:37 +0100
From:	"Duane Griffin" <duaneg@...da.com>
To:	"Andrew Morton" <akpm@...ux-foundation.org>
Cc:	sandeen@...hat.com, cmm@...ibm.com, sct@...hat.com,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 2/3] jbd: tidy up revoke cache initialisation and destruction

2008/5/10 Andrew Morton <akpm@...ux-foundation.org>:
> On Sat,  3 May 2008 17:47:14 +0100
>  "Duane Griffin" <duaneg@...da.com> wrote:
>
>  > Make revocation cache destruction safe to call if initialisation fails
>  > partially or entirely. This allows it to be used to cleanup in the case of
>  > initialisation failure, simplifying that code slightly.
>
>  This crashes the kernel early in boot.  Too early to catch via netconsole,
>  which is a bit odd.

Eeek, yes, an extremely silly bug. Sorry about that. I'll send a
revised version of the patch-set shortly, and this time I'll make sure
it is properly tested.

>  I also have a feeling that [patch 1/3] causes problems too but I've run out
>  of time to bisect it further.

Was there something in particular that worried you about it? I've gone
back and done some more testing with just that one, including testing
each of the error cases manually, and all looks fine.

Cheers,
Duane.

-- 
"I never could learn to drink that blood and call it wine" - Bob Dylan
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ